Shantanu

Results 383 comments of Shantanu

Marking this as deferred for now, in case we're able to find a good mypy fix in the next several days :-) (Will definitely make sure there's something in place,...

Hmm, it appears actions do not trigger unless you close and open the PR manually :-/

As mentioned in https://github.com/python/typeshed/issues/8403#issuecomment-1197251076 , a major version change is a good opportunity to drop the `__init__.py` , see https://github.com/python/typeshed/issues/7519

I think the plan is to make use the opportunity of the major version bump of protobuf removes the `__init__.pyi`. This caused a lot of problems when we tried it...

Nipunn is correct that we need to use `--explicit-package-bases` and add all stubs to MYPYPATH (or copy files to a different kind of directory structure and check them). I don't...

This shouldn't have any impact on users who install stubs. The issue here is that in our CI we pass some filenames to mypy and mypy needs to convert filenames...

Note the stubtest third party code already does this venv creation. We could steal that code / maybe use some fancy Github Actions CI caching to cache venvs across workflows....

That sounds reasonable. Some thoughts: - It might make sense to split each test up into running on the stdlib vs running on individual third party distributions (like we do...

I removed the good-first-issue label since some of these are fairly complicated to fix "right", see discussion in #4282 However, there are likely some easy fixes in here as well...

There isn't a great way; how best to type it depends on how exactly you're using it. Also willing to bet that the stubs could be improved (e.g. looks like...