haszi

Results 49 comments of haszi

> `CURLOPT_FNMATCH_FUNCTION` and `CURLOPT_HEADERFUNCTION` are already properly handled there (see the "callables" section at the top of that `switch` (macro magic). @cmb69 Sorry that I wasn't specific enough but I...

> @haszi, I've actually debugged `CURLOPT_FNMATCH_FUNCTION` and `CURLOPT_HEADERFUNCTION` on master, and both are properly type checked. As of [php/php-src#13291](https://github.com/php/php-src/pull/13291), this happens due to `HANDLE_CURL_OPTION_CALLABLE(ch, CURLOPT_FNMATCH_, handlers.fnmatch, curl_fnmatch);` and `HANDLE_CURL_OPTION_CALLABLE_PHP_CURL_USER(ch, CURLOPT_HEADER,...

@Girgias I've added some applicable tags, information on what type of value each option accepts and (where known) what the default value is.

> > Not sure if the acronym tag comments are that useful as it would be adding a lot of them > > At least adding some would be great!...

One more thing in regards to acronyms: we should probably add an `ENTITY` for at least the most frequently used ones (eg.: HTTP, FTP, SSL/TLS, etc.) so that we can...

This PR is now ready for review. The build failure is due to this PR only working in tandem with the accompanying `doc-base` PR (https://github.com/php/doc-base/pull/138) as the overall hierarchy of...

Please advise whether we can move forward with this and the `doc-base` PR or if I need to make any changes to this PR. If this gets merged, I can...

> @haszi do you think this makes sense, and is this not too complicated to add support to PhD for it? This is very much in line with the new...

Since all enums implement either the [UnitEnum](https://www.php.net/manual/en/class.unitenum.php) or the [BackedEnum](https://www.php.net/manual/en/class.backedenum.php) interface and inherit their default method implementation, all enum markup will have to include both an `` and a ``...