haszi

> @haszi are the ID changes for the class constants an issue for linking? Unfortunately they are. Class constant IDs are linking to their declaration only if they are in...

> That may work in these specific cases, but we should rather solve the general issue I think 🤔 because the generator should produce valid code IDs of classes are...

Could you drop the leading and trailing hyphens from `FFI::__BIGGEST_ALIGNMENT__`'s ID? Leading and trailing hyphens were dropped from IDs as suggested [here](https://github.com/php/doc-en/pull/3208#discussion_r1507733277) and [here](https://github.com/php/doc-en/pull/3214#discussion_r1507735600) (and implemented in PhD [here](https://github.com/php/phd/pull/106)).

> There are a few properties which start with a double hyphen, like `SoapClient:: $__soap_fault`. Do we want to remove them as well or are we fine with them? Since...

> I think this looks good, @haszi can you confirm? Looks good to me.

When `PhD` is retrieving the indexes from the database, all function/method names are stored in memory with `::` and `_` replaced by `-`. That is not an issue for most...

> I honestly don't know the difference between a book and a set A book is a "complete book" and a set is a collection of books and is the...

I've opened a PR in `doc-base` (https://github.com/php/doc-base/pull/138) and `doc-en` (https://github.com/php/doc-en/pull/3627) to address this. Please note that the changes made in the `doc-en` PR will have to be made in all...

@jrfnl The `doc-base` and documentation repository PRs have been merged.

> The lack of support for XInclude 1.1 is really annoying.... If only we had attribute copying or `set-xml-id` attribute support from 1.1... :-)