Yang Jun comments

Results 206 comments of


                                            Yang Jun

liquid.node.esm.js breaks in module context

Please try v10.16.5, added some checks for the demo cases including esm scenario. More complex scenarios like in-browser rendering is not checked in real browsers yet. Will do latter, but...

block.super does not work with strictVariables: true

Thanks for the investigation! Will look into this in a couple of days, and feel free to file a PR if you’re interested.

Liquid template can't find include file with relative path

> What does "." mean in this context? `"."` means CWD. > The following test case fails via node standalone.js in your repo, which is surprising to me: @zachleat Thanks...

All render methods return `any` or `Promise<any>`

It’s for keepOutputType, when set and only one token is rendered. We can improve typing by overloading I guess. I am happy with exposing additional types :)

Support Value Expressions as Operands in Conditional and Loop Tags

Both extending expression syntax and adding operators sound good to me. I've thought about this idea years ago when I find Liquid language is still tedious thus not perfect in...

LiquidErrors not exported

Investigated and turns out to be not easy be fully typed here, depends on #832 thus moved this issue to v11.