Yang Jun comments

Results 196 comments of


                                            Yang Jun

trafficstars

Support for all built-in Jekyll filters: slugify, number_of_words, date_to_xmlschema, date_to_rfc822

No worry, there's a lot work remaining anyway. Thanks for your effort.

Support for all built-in Jekyll filters: slugify, number_of_words, date_to_xmlschema, date_to_rfc822

Added group_by, group_by_exp, find, find_exp in the latest version, @bzerangue please try v10.11.0

Building a tag that does not render but needs to do something

I think you should remove the line with “ this.stream.on”, it’s used to parse children templates and the debug tag has no children.

Add ability to specify the files to read/write

Do you mean the dev files, or config files?

Fix: Add pipes to start and end of lines

Thank you for contributing to this tiny repo. @AhmedThahir But always adding pipes is as bad as always not adding pipes. We need check whether there's pipes in input and...

Handling DoS loops or max time processing

Not available currently. But I think it's OK to have this feature, are there any other libs implementing this, for reference?

Handling DoS loops or max time processing

I guess limiting the processing time is better handled by external libraries. Closing this issue.

Handling DoS loops or max time processing

I thought Shopify doesn't have a limit on this. Will investigate whether we can do the same.

is {%else if foo %} valid syntax?

Though we don't replicate many of error scenarios in Shopify, consistency is always good. I think we can leave it as it is, as it's already consistent with Shopify.

Handling DoS loops or max time processing

Added DoS related support: https://liquidjs.com/tutorials/dos.html