Harshith D
Harshith D
Thank you for the positive feedback! I've already implemented the feature with full backwards compatibility as requested. I've created issue #1401 to track this feature request, and I'm now preparing...
> can you look through the docs and update the CLI portion with this please? I'd like to ensure that a new user could follow the instructions to set this...
> CC @zilto since you designed most of the CLI stuff. @zilto Thank you for your oversight of the CLI design! I've updated the documentation to include comprehensive information about...
I've addressed all the feedback with these changes: 1. **Documentation**: Updated CLI reference and pre-commit hooks docs with comprehensive TOML support information 2. **Dependencies**: Added `tomli` to CLI optional dependencies...
First Issue Response: Regarding the import tomli statement that "doesn't seem useful" - I removed the debug file (debug_toml.py) that contained this unnecessary import. The file was just loading a...
Hi *skrawcz* , I've verified the content of the pyproject.toml file in the current repository, and I can confirm that `tomli` is indeed correctly included in the `cli` dependencies section...
Thanks for the feedback! On Tue, 7 Oct 2025 at 09:39, Stefan Krawczyk ***@***.***> wrote: > *skrawcz* left a comment (apache/hamilton#1402) > > > Hi *skrawcz* , I've verified the...
Hi *skrawcz.* I've resolved the pre-commit errors that were occurring in the Hamilton project: 1. Fixed the B904 error in hamilton/cli/logic.py - changed the exception handling in the _read_toml_context function...
Hi *skrawcz.* I've fixed the pre-commit hook issues that were causing problems: 1. Ruff pre-commit hook failures: I found that some files in the examples directory (like examples/dask/hello_world/business_logic.py) were just...
Hi Akashdeep Dhar. Just wanted to let you know that I've fixed the pre-commit coverage issue. The problem was that some lines in the meets_requirements_why method weren't covered by tests,...