Harry John
Harry John
It's not being worked on currently. I was merely pointing out that we can copy most of the Cortex code as is into Thanos. Thanks for submitting this feature request.
I think we need to have some validations on this API for checking whether a limit update is within a safe ranges. Also, not all limits should be allowed to...
This is a hard limit in the symbol table size in Prometheus TSDB of 4GB. See: https://github.com/prometheus/prometheus/blob/main/tsdb/docs/format/index.md#symbol-table. The length field in the symbol table cannot exceed 4 bytes which limits...
> I have checked this out but it is super unclear to me how i would apply this. I'll admit that I haven't used this myself. Full disclaimer, I work...
> The tests themselves look good, do we need to bump Prometheus? @MichaHoffmann - I have opened a couple of PRs in Prometheus to implement the limit param in mergeQuerier...
> Quite a lot of tests failed due to round. Should we add my fix to round function to see how much it would help? @yeya24, I tested your [fix](https://github.com/prometheus/prometheus/commit/b7aca45de7e40b7e99949480bfdfa3e188a0344b)...
@aknuds1 - I think it makes sense to pass the limit into LabelValues() and only read up-to the limit values from posting-offsets table. https://github.com/prometheus/prometheus/blob/911c3efb96093a010e0ddd08c50db5e320ee2ecb/tsdb/index/index.go#L1550 For LabelNames(), all the names should...
#598 - Implement timestamp() for native histograms
#596 - Fix output series ID for native histogram binary operations
#595 - Fix sort() for native histograms