Harry John

### Test 1: without enabling the max_fetched_data_bytes_per_query #### Limit ``` max_fetched_chunks_per_query: 20000000 max_fetched_series_per_query: 12000000 max_fetched_chunk_bytes_per_query: 750000000 ``` #### Result ``` ➜ ~ awscurl --region us-west-2 --service aps -X POST "https:///api/v1/query"...

LGTM! Congrats on your first OSS PR Juan.

> After this is in place, we could also make use of that limit hint for `storage.remote.read-sample-limit` https://github.com/prometheus/prometheus/pull/4532/files @machine424 - Sorry, I didn't understand how the sample limit is relevant...

Hey @bboreham, could you please take a look at this PR?

> If I read this correctly you didn't implement early exit when the limit was hit; just added the interface so that someone else could do that. This seems wrong...

I took a stab at implementing the limits inside merge.go I included those changes in the same PR as changes seemed minimal. Could you take another look @machine424 and @bboreham...

> I'd proceed as we agreed: merge the PR with the interface changes only (I already approved those) if no one has an objection, and then add the implementation in...

Could this PR be merged if there are no objections?

Let me try to summarize my understanding of the approach in Thanos. Please correct me if I'm wrong. - Queriers in Thanos implements the `Query` gRPC service ([code](https://github.com/thanos-io/thanos/blob/main/pkg/api/query/querypb/query.proto#L103)). - Has...

> "An optimizer embedded in the query-frontend is aware of how the data in the storage layer (ingesters and store-gateways) are partitioned. The optimizer creates an optimized query plan." >...