Paddy Harrison comments

Results 53 comments of


                                            Paddy Harrison

Using scipy's Rotation object

@argerlt thanks for opening the issue! I have used SciPy's `Rotation` objects myself in the past and they work well and come with a lot of benefits as you mentioned!...

Using scipy's Rotation object

@argerlt thanks for opening this issue and for doing the tests above, it's always good to get a second opinion. It confirms to me that moving to `numpy-quaternion` was a...

Accommodating symmetry (which applies to Orientations but not Rotations) in the inheritance structure

@pc494 sounds like a good idea. I agree with what @hakonanes has suggested here. A private `_symmetry = None` class attribute for `Rotation` seems okay but I don't think an...

Accommodating symmetry (which applies to Orientations but not Rotations) in the inheritance structure

After #302, and dealing with the problem of inconsistent output shapes from `Rotation.dot_outer` and `Orientation.dot_outer`, this PR seems like a good idea. To implement this, would it make sense to...

Accommodating symmetry (which applies to Orientations but not Rotations) in the inheritance structure

> I was thinking to distinguish between a rotation and an orientation by checking whether symmetry == None. How do you plan to make this distinction if it is set...

Accommodating symmetry (which applies to Orientations but not Rotations) in the inheritance structure

Just a second comment, if we give `Rotation` instances `C1` symmetry then `Symmetry` instances will also have symmetry through inheritance. Personally I don't think this makes sense, and may lead...

Phase.from_cif() test fails in Windows with diffpy.structure 3.0.2

Thought this may be the case!

Add class method 'from_align_vectors()' to Quaternion, Misorientation and Orientation

Thanks for the ping @hakonanes, I will try to have a look a this before tomorrow!

Add class method 'from_align_vectors()' to Quaternion, Misorientation and Orientation

Sorry for the delay all, and thanks for the interesting discussion! My only comment regarding inverting or not the Scipy rotation is that we document it in `Notes` of the...

Change rounding from 12 to 10 decimals when finding unique vectors and rotations

@hakonanes thanks for doing this, I seem to remember we foresaw this problem at the time. I wonder whether you think there is any utility in rounding to 10dp, or...