Paddy Harrison

Results 53 comments of Paddy Harrison

I'd like to add that on MacOS I do not receive this error when launching the app by clicking the app icon. If I launch from the terminal, however, ie....

+1 for this. In my testing adding 45 deg. azimuthal rotation also appears to rotate around the z-axis (blue), not y (green): ```python import sys from vispy import scene from...

@djhoese thanks for the advice and quick review! I just undid some auto-formatting changes that were committed. This PR should be okay for a second look!

Should be able to make the tests pass by adding the `-` sign back here: https://github.com/vispy/vispy/blob/fcc0139ba9c4e7dc655a663c075e3973f1c73e25/vispy/scene/cameras/turntable.py#L142 although I believe this means that the rotation around the x-axis (`elevation`) is in...

> Is there a way we can somehow deprecate it and let people "opt in"? Would a `UserWarning` informing people of the future change on instantiating `TurntableCamera` and a `use_updated_transforms`...

I think that would be a safe way to implement the change and would give users warning about it. Happy to implement this if you like the idea!

You can test out the UX differences by running this script (based on the failing test @djhoese mentioned above: https://github.com/vispy/vispy/pull/2352#issuecomment-1177892006): ```python from types import MethodType from vispy import io, scene...

@brisvag sorry for the delay, I have been busy lately. I will take another look at this over the weekend!

@brisvag I have had another look over this and updated the tests. Effectively this PR clarifies the `TurntableCamera` docstrings to clarify the interaction and allows programmatic adjustment of the `roll`...

@djhoese thanks for reviewing, I have updated the docstrings with your suggestions. Hopefully the information comes across more clearly now.