Stéphane Klein

Results 43 comments of Stéphane Klein

This pull request can be accepted? Why it is in standby?

@xiaket > I have documented a solution here in my blog: https://blog.xiaket.org/2017/exposing.ssh.port.in.dockerized.gitlab-ce.html > > Hope you'll find it helpful. Yes, it is helpful. My note, be careful, with this detail:...

Implementation proposal: https://github.com/sameersbn/docker-gitlab/pull/1731

``` $ go version go version go1.7.1 darwin/amd64 ``` ``` $ go get -v all github.com/golang/lint/golint github.com/jcuga/golongpoll/examples/basic github.com/kisielk/errcheck github.com/klauspost/asmfmt/cmd/goimports github.com/klauspost/asmfmt/cmd/gofmt github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio golang.org/x/tools/cmd/goimports sourcegraph.com/sqs/goreturns # github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio ../../../go/src/github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio/file.go:45: undefined: syscall.Overlapped ```

@reubano I think because too many incompatibility.

@jamesonjlee Ok, I've appended one test for this bug. Without my patch, this new test fail with python 3.4