python-consul icon indicating copy to clipboard operation
python-consul copied to clipboard

FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited

Open ashwini-balnaves opened this issue 7 years ago • 8 comments

Resolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).

ashwini-balnaves avatar Aug 21 '18 05:08 ashwini-balnaves

@matusvalo did you have time to have a look at this one?

wdauchy avatar Oct 02 '18 13:10 wdauchy

Can anyone merge this pls?

Pavkazzz avatar Oct 05 '18 14:10 Pavkazzz

@cablehead Looks ok, merge please

habibutsu avatar Oct 16 '18 16:10 habibutsu

Ping @cablehead

harobed avatar Feb 03 '19 15:02 harobed

Any news on this being accepted?

icaropires avatar Jul 23 '19 15:07 icaropires

@matusvalo @abn @cablehead Guys! Are you still maintain this package?

habibutsu avatar Sep 05 '19 10:09 habibutsu

I built own package with some PRs and uploaded it to PyPi till not released new version, maybe it would be useful for someone

https://pypi.org/project/habibutsu.python-consul/1.2.0/

habibutsu avatar Sep 05 '19 17:09 habibutsu

I this PR abandoned by the authors? we need to merge that guy it's already overdue. I'm happy to help if I can in anyway

sheshtawy avatar Mar 17 '20 00:03 sheshtawy