harish1996 comments

Results 5 comments of


                                            harish1996

Only One Page

This is one major issue that i observed while trying to use this. Please add this feature.

Error is throwing while installing Hellinger distance criterion from setup as suggested in https://github.com/EvgeniDubov/hellinger-distance-criterion

Could you please mention the version of cython and sklearn used here ?

Error is throwing while installing Hellinger distance criterion from setup as suggested in https://github.com/EvgeniDubov/hellinger-distance-criterion

Refer #13

Update hellinger_distance_criterion.pyx

Kindly take a look at this issue https://github.com/EvgeniDubov/hellinger-distance-criterion/issues/4. I am yet to take a look at scikit-learn 1.x, but are you sure Cython supports a list as a subscript ?

Update hellinger_distance_criterion.pyx

I just went through the changes in scikit-learn and cython 3+, and it looks like i rushed while commenting previously. The fixes suggested in this looks to support scikit-learn >...