Hareesh Nagaraj

Empty string evaluated as 'true' for Boolean config

4

Given a config with the following definition: ``` myTestConfig: { format: Boolean, env: 'myTestConfig', default: false } ``` An environment variable set to `myTestConfig=''` is evaluated as true. Consistently reproduced...

3.5 - Inconsistent Usage of SafeMath

2

### Description Remove base arithmetic operations in favor of SafeMath where relevant ### Tests Existing tests pass ### Monitoring - How will this change be monitored? Are there sufficient logs...

### Description Remove ability for stakingAddress to be updated after it is initially set (per feedback). ### Tests Many minor test modifications required in order to accommodate this change ###...

### Description Explicitly ensure that votingPeriod + executionDelay is less than decreaseStakeDuration ### Tests New test case added with repro prior to solidity changes but will not pass after fix...

### Description Add requireIsInitialized checks where missing for consistency ### Tests Existing tests pass ### Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

### Description The initiateRound functions approves a transfer; however, this allowance is not used by the safeTransfer. ### Tests Existing tests pass ### Monitoring - How will this change be...