Harshal Patil

Results 150 comments of Harshal Patil

We need to bump up the crio commit in upstream node e2e tests and see if they pass fine.

Thanks @TheDiveO for submitting this issue. Coincidentally, I have been experimenting with the idea of adding events stream from the runtime to the kubelet. Its still in it's early stage,...

> What do you think of such a more general topic-based approach as found in containerd? Containerd is composed of several independent `plugins` that need much more richer eventing mechanism....

Thanks @TheDiveO, I have added `CREATED` and `STARTED` to the [ContainerEventType](https://github.com/harche/kubernetes/blob/event_pleg/staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto#L151) cc @haircommander

Rough skeleton code for crio - https://github.com/harche/cri-o/commit/0da45f74196ca9e2615a7d1146d930f986591c69

> Is there a comparably simple way I could test drive your changes on a local development system, with a simple cri-o binary? You will have to start the crio...

@thediveo BTW, there is another PRs where CRI related discussions are taking place - https://github.com/kubernetes/kubernetes/pull/110165

After cloning kubernetes, and bringing up crio, ```bash sudo make test-e2e-node RUNTIME=remote CONTAINER_RUNTIME_ENDPOINT="unix:///var/run/crio/crio.sock" FOCUS="\[NodeConformance\]|\[NodeFeature:.+\]" SKIP="\[Flaky\]|\[Slow\]|\[Serial\]" TEST_ARGS='--kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' ``` This works on Fedora...