Harald Hoyer

fix(sockets): preopened directories first

1

Existing libraries and applications use `fd_prestat_get()` to find out about preopened directories. To not break the old logic of those, if preopened sockets are added, push the directories first. Fixes:...

98integrity/ima-keys-load.sh: bad style `for file in $(ls <dir>)`

2

https://github.com/dracutdevs/dracut/blob/c5dd11f99fb54937346eaee7c224ff8c7527298c/modules.d/98integrity/ima-keys-load.sh#L20-L21

run `systemctl --root="$dracutsysrootdir" enable dbus.socket`

3

Run `systemctl --root="$dracutsysrootdir" enable dbus.socket` ? _Originally posted by @mikhailnov in https://github.com/dracutdevs/dracut/issues/1396#issuecomment-828588685_

95zfcp_rules: bad style var=$(cat <file>)

2

use `read -r var < file` https://github.com/dracutdevs/dracut/blob/3a04fdff87b5684bfa6c4bdd2a047fc12748c7ce/modules.d/95zfcp_rules/parse-zfcp.sh#L47-L49

Document shell testing

1

yeah.. positiv testing is preferred here ``` [[ $is_crypt == "crypt" ]] || continue ``` as it catches the error case here. `$?` is zero for the following commands or...

add `add_optional_drivers` option

1

**Describe the enhancement** Install a kernel module optionally and don't error, if it does not exist. See also https://github.com/systemd/mkosi/pull/680

Possible strategy: Since bash assigns `var+="foo bar"` to the first array index, we could increase the array index beforehand manually and later on only split `${var[0]}` via IFS and push...

https://bugzilla.redhat.com/show_bug.cgi?id=849338

In the terminal an error message is not distinguishable from an info message. Maybe: ```diff --- a/dracut-logger.sh +++ b/dracut-logger.sh @@ -323,7 +323,7 @@ _do_dlog() { local msg="$*" local lmsg="$lvlc: $*"...

"bind-mount" kernel drivers in real root for the e.g. the rescue image, if the real root does not have any kernel modules for this kernel see https://bugzilla.redhat.com/show_bug.cgi?id=1046510 This can be...