Hamzah Qudsi

Results 13 comments of Hamzah Qudsi

ah I see. Reviewing you're profile again, it's spending pretty much all of its time on the K8sWatcher side. The other fix addresses an issue on the other side -...

in order to specify label selectors per resource, let's create a new env var idk call it `AMBASSADOR_WATCHER_LABEL_SELECTOR` and we can mark the `AMBASSADOR_LABEL_SELECTOR` as deprecated to be removed in...

> New functionality implemented, docs here: [datawire/ambassador-docs#700](https://github.com/datawire/ambassador-docs/pull/700) I also added the same for the field selector (which was not even documented before). > > Two comments, > > * When...

Hi @raffis sorry for the delay got busy with other things. So change wise it looks good to me but I brought this up to the rest of the Maintainers...

@LukeShu forgot this after our 3.2.0 and 2.4.1 releases but let's get this landed. Updating for dependabot stuff is going to get noisy

> @LukeShu @haq204 - I don't see an issue with the proposed changes but I guess why is it that we are keeping the vendor folder around at all? >...

approved on the basis of not holding up with the logging comment. I'm ok if its omitted

we might need to rebase master onto this to resolve the merge conflicts

@ppanyukov the `selector` field is deprecated in favor of `mappingSelector`. Testing using `mappingSelector` on `getambassador.io/v3alpha1` on v3.8.0 I was able to get it to route correctly: ``` 2023-09-05 22:46:03 diagd...

after syncing with @LanceEa and @LukeShu offline, we decided to keep `go mod vendor` for the following reason: - we want to download the packages outside the docker build to...