happyCoder92

Results 17 comments of happyCoder92

file_wrapper allows invalid namespace names

This is quite minor as it's a build tool backing sapi_cc_embed_data rule. Happy to accept PRs for that issue.

Cannot build with Fedora-provided dependencies

Could you provide more details about the error/missing targets? AFAIR deps for Fedora were only provided in a github issue comment and that might be out of date.

Storybook export?

There is a "Quick start" section in the main README. https://github.com/google/sandboxed-api#quick-start It also lists the required dependencies for Debian 10 Buster (other distros to be added - tracked as #16).

Memory leak - buffer stack cleanup

Even the example scanner from Multiple-Input-Buffers docs section if you try to include a non-existent file in yet another included file. Compiling with ASAN will make spotting the memory leak...

scanner: fix buffer stack popping in yylex_destroy

Rebased.

Add special rules for generated headers

Hi! This looks good. Can you, please, resolve the problem with missing CLA though? :)

nsjail cannot find executables even with the entire root directory mounted?

I could not reproduce the issue. What OS are you using?