kafel icon indicating copy to clipboard operation
kafel copied to clipboard

Add special rules for generated headers

Open steelman opened this issue 2 years ago • 3 comments

bison(1) and flex(1) pose a problem for make(1) because they generate many output files. These files when properly added to dependency tree may make make(1) run rules to generate them twice depending on timing which in turn results in a race condition and failed build especially on heavily loaded systems.

To aviod that special rules that serialise dependencies need to be introduced which is what automake(1) has made for long time.

https://git.savannah.gnu.org/cgit/automake.git/commit/?id=788a63b300568b1c1876e4ad30b966df2f0710fc

Additionally to avoid problems when running make -n, rm(1) and make(1) commands need to be placed under separate if statements.

https://git.savannah.gnu.org/cgit/automake.git/commit/?id=d7c1679b14c1ab691927f3243df1cb3cbb2360aa

steelman avatar Aug 03 '23 11:08 steelman

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 03 '23 11:08 google-cla[bot]

Hi! This looks good. Can you, please, resolve the problem with missing CLA though? :)

happyCoder92 avatar Aug 18 '23 11:08 happyCoder92

I am working on it.

steelman avatar Aug 25 '23 09:08 steelman