haowu14

I'm in the process of reviewing. I am curious that do we have to associate a path and a name with each file segment? Can we use only name to...

It's this and why we need to have each FileSegment have a path instead of just a name and figure out the path from the name. Just like Posix always...

Thanks for clarifying. Is it correct that in the future it will be possible for the same shmManager to mount different types of segments (tier 1 is file, tier 0...

Hi! Thank you for making the change. We discussed internally on how we can bring FileShmSegment into cachelib and allow compatibility. We'd like to suggest the following change (your PR...

Hi! We found a problem in NvmCacheTests.ConcurrentFills that under a certain race condition it fails. We will be working on fixing this.

@vicvicg Do you still see test failures in the built?

I thought we have a histogram-based latency tracker already enabled for the allocation. Is there any reason to add this one?

@vinser52 In the middle of reviewing this. I can publish some of the comments later today.

Hi, you can bypass this by changing "tickerSynchingSeconds" to 0 (or remove it from your cachebench config). There is a known issue in ticker syncing that sometimes would cause the...

Dependencies are fixed. On Ubuntu 22 there's a cachelib compilation failure. Attempting a fix. ``` In file included from /home/runner/work/CacheLib/CacheLib/cachelib/allocator/tests/ChainedHashTest.cpp:18: /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h: In member function ‘void facebook::cachelib::tests::AccessTypeTest::testIteratorMayContainNull()’: /home/runner/work/CacheLib/CacheLib/cachelib/../cachelib/allocator/tests/AccessTypeTest.h:596:49: error: need ‘typename’...