Haolin Wang comments

Results 44 comments of


                                            Haolin Wang

docs - set superuser_reserved_connections GUC default to 10

@litzell and @dyozie, as I checked this doc change is consistent with the code, so could you proceed to merge ?

[WIP]Resolve GPDB_12_MERGE_FIXME in test: index_constraint_naming_upgrade

I'm really hard to understand the commit message, could you describe it more straightforward and put the key point or problem before other detail explanation ? Thanks.

[WIP]Resolve GPDB_12_MERGE_FIXME in test: index_constraint_naming_upgrade

> EXCHANGE PARTITION, master changes the constraint/index name, it behaves differently with 6x: @QingMa-gp look, seems I'm not the only person who misunderstood your description, right ? ;D

Enable quicklz tests during ICW

@bradfordboyle Is this PR still needed to proceed ? Seems long time no activity, if no more action on this, is that OK to close ?

Add throttle logic to slow down WAL writes in CATCHUP phase.

> Started to review this PR. Will try to provide most of my comments by this week. Thanks!

Add throttle logic to slow down WAL writes in CATCHUP phase.

I have updated the code to incorporate with the comments and had a preliminary test against 6X_STABLE in the lab. The result as below: concurrency: 100 clients throttle record size:...

Add throttle logic to slow down WAL writes in CATCHUP phase.

Thanks for reviewing this, @divyeshddv. I agree on taking the first commit forward and leave the second there for further evaluation.

Refine logic in gp_bash_functions.sh

@BaiShaoqi Does this PR still need further action ? Or is it OK to close if no need to proceed ?

Reduce TCP port usage on the QD

Do we really need SO_REUSEADDR for non-binding ephemeral ports on QD (client of segment ?) side ?

Reduce TCP port usage on the QD

> > Do we really need SO_REUSEADDR for non-binding ephemeral ports on QD (client) side? > > I thought it works for outgoing connections too, #577 said so. I will...