Hanyu Zheng

Results 31 comments of Hanyu Zheng

@dawidwys @MartijnVisser I think we can change the description, If the delimiter is empty, we will return entire string. Now we use `splitByWholeSeparatorPreserveAllTokens`, when delimiter is empty, it will return...

@dawidwys So we can use `splitByWholeSeparatorPreserveAllTokens` when the `delimiter` is not empty. When the `delimiter` is empty, do we need to handle this situation specially?

> > When the delimiter is empty, do we need to handle this situation specially?/ > > Yes, we do. Do you mind updating the PR? I have already updated...

@snuyanzin I have already solve all the comments, could you please do the second code review. Thank you.