Han-Wen Nienhuys

Results 206 comments of Han-Wen Nienhuys

implemented in https://github.com/hanwen/go-fuse/commit/e0a0b09ae8287249c38033a27fd69a3593c7e235

612c80e9b0f2eb7495205901747e87889a0bddcf

I have this, and it seems to work. ``` func shadowRootOf(wd selenium.WebDriver, host selenium.WebElement) (selenium.WebElement, error) { root, err := wd.ExecuteScript("return arguments[0].shadowRoot", []interface{}{host}) if err != nil { return nil,...

I guess that is a defensible stance, but who is your target audience? i imagine that people who are accustomed to Go are going to find GopherJS more interesting than...

I think we misunderstand each other. My suggestion is to use the name SetHTML rather than the current SetHtml. Similar for other names with abbreviations.

Maybe effective Go should also be updated, but the precedent in the standard lib is clearly there. See eg. function names in https://golang.org/pkg/crypto/rsa/ https://godoc.org/honnef.co/go/js/dom looks to follow the standard. It...

I think the best way to solve this is init'ing the map from a `struct { flag uint; name string }` and remove 0 or duplicate flags.

see https://review.gerrithub.io/c/hanwen/go-fuse/+/1199540 and https://review.gerrithub.io/c/hanwen/go-fuse/+/1199539

I am looking at go-fuse on OSX, and it seems that FOPEN_KEEP_CACHE doesn't work on OSXFUSE; the test case I have for this fails. OSXFUSE seems to ignore the attribute...

when adapting for openat(), you have to get the 2nd argument to the syscall (from RSI), rather than the 1st. Alternatively, ``` struct ptrace_syscall_info info = {}; int err =...