dongwang comments

Results 32 comments of


                                            dongwang

Avoid unnecessary transfer and notify behavior when execute rebalance

what do you think? @johnou @jhalterman

[Iceberg]Support non-identity partition predicate for thoroughly push down

Convert to draft as this PR depending on #21959. So it should be reviewed after #21959 is merged.

[Iceberg]Support non-identity partition predicate for thoroughly push down

> Is this a cherry pick? At first glance, I don't see substantial similarities with the referenced PR. I referenced the implementation of trino, which may evolve gradually through a...

[Iceberg]Support non-identity partition predicate for thoroughly push down

> Based on my reading of the code, this wouldn't qualify as a cherry pick as it's substantially different, and even the way it's performed is different between the two...

[Iceberg]Support non-identity partition predicate for thoroughly push down

> Instead of making changes directly to `Type`, can we just have a new utility method in the Iceberg connector which takes in the Type, the Object, and from those...

[Iceberg]Support non-identity partition predicate for thoroughly push down

> I think we can start in the Iceberg connector, and extract if or when an additional use case comes along. Good idea! Have done this, please take a look,...

[Iceberg]Support non-identity partition predicate for thoroughly push down

Hi @ZacBlanco, I have combined `getPreviousValue()` and `getNextValue()` to a single function `getAdjacentValue()`, and used `anyNot(...)` to extract functions `thoroughlyPushdown(...)` and `notThoroughlyPushdown(...)` which could have a more clearer meaning. Then...