Hanno Braun

Results 489 comments of Hanno Braun

I've read through this and can't see anything terribly wrong. Then again, I have never though a lot about this kind of library beyond the basic "I need to monitor...

> having the inotify crate expose a futures::Stream (I suppose?) I suppose so too, but I'm not sure yet. Originally I thought I just need to return an `Iterator` instead...

@passcod I finished my overhaul of the inotify-rs API. There's still [stuff to be done](https://github.com/hannobraun/inotify-rs/issues), but I decided to declare victory for now, and circle back for the rest of...

I'd like to note that this was only the first step towards a larger refactoring. The end goal is to create a HAL-level `Peripherals` struct that wraps the PAC-level `Peripherals`....

But whether you buy into my grand vision or not, I believe that replacing extension traits with plain constructors is worthwhile, for the reasons mentioned.

@nickray > As an example: This L4 chip series has a lower voltage range mode [...] At least in this case, an "unfreeze" might be able via some tricks to...

Okay, looks like this won't work with Rust 1.31.0. I've converted this pull request into a draft, in case the minimum supported Rust version will be increased any time soon....