hanmz

[email protected]

Results 6 comments of


                                            hanmz

[fix][broker] Introduce the last sent position to fix message ordering issues in Key_Shared (PIP-282)

LGTM

[fix][broker] Remove delta when calculating msgRateRequiredFromUnloadedBundles and msgThroughputRequiredFromUnloadedBundles for UniformLoadShedder

> could we add a test for this case ? Okay, I'll add a test case here

[fix][broker] Remove delta when calculating msgRateRequiredFromUnloadedBundles and msgThroughputRequiredFromUnloadedBundles for UniformLoadShedder

Please help me find out what is the purpose of adding delta=1000 here? @lordcheng10

[fix][broker] Remove delta when calculating msgRateRequiredFromUnloadedBundles and msgThroughputRequiredFromUnloadedBundles for UniformLoadShedder

> @hanmz Could you merge the master branch, and then the CI is passed, I will merge this PR. Okay, I'll do it. Please help look again

[fix] [broker] Fix replicator send message error but cursor not set back to rewind position

Can we add a test for this case?

[fix] [broker] Fix replicator send message error but cursor not set back to rewind position

I suspect this has something to do with the version you are using. I suggest you try it on the latest version.