Hang Yan
Hang Yan
> @hangyan @tnqn @antoninbas : I feel packet capture is a better name than packet sampling for this feature. What you think? I don't have a strong opinion before but...
> can someone remind me why we only support SFTP instead of a direct download URL like for supportbundle? I couldn't find this information anywhere. cannot recall why for now...If...
> Hi @hangyan I have moved this PR out of v2.0, could you please create a separate PR for API first. We can do a further discussion for the data...
@shi0rik0 Please take a look if you are interested.
Also, yaml and lint tests should pass
seems the build CI faild.
moved API to this MR. Thanks you previous feedback and welcome to help review this again. @luolanzone @tnqn @jianjuns @antoninbas Accoding to https://github.com/antrea-io/antrea/pull/5821#discussion_r1575226623 . `IPHeader` field was removed.
@jianjuns Do you think we can add a ip family and ip protocol field? so we can remove ipv6header and icmpheader.
> > @jianjuns Do you think we can add a ip family and ip protocol field? so we can remove ipv6header and icmpheader. > > That works for me, if...
@antoninbas @jianjuns @tnqn Any new comments?