Hang Yan
Hang Yan
@cdrage can we remove the `semaphoreci ` test step?
@cdrage I'm not sure how to remove this? I remember trying to do so a long time ago, didn't get any luck. Will look into the ci failures.
@sudo-NithishKarthik What's your go version? Can you confirm the go mod is tidied in both golang 1.16 and golang 1.17
Looks good. Thanks
@luolanzone Here is the current PR for packet sampling. If you think more information was needed to help review this, let me know and I will update this ASAP. currently...
@luolanzone Hi lan, all updated. will make sure the golangci-fix pass and import order is correct in the following commits. Please have a review again
hi @tnqn @wenyingd @gran-vmv Can you help review this PR too? Currently i'm working on finishing the unit tests and i think the main code is ready. Thanks!
@luolanzone @tnqn @wenyingd Can you help review again ? Thank you. accoding to @tnqn 's comments, seems use DSCP in packet is unnecessary，so i swithced the implementation to use ovs...
@tnqn @luolanzone Can you take a look at this again? Thank you
> @hangyan I updated the PR description to fix some typos and grammars. Thank you. I will check you other comments as well. Will reply ASAP.