Hang Shao comments

Results 66 comments of


                                            Hang Shao

Use primitiveObjectHashCode function when hashing value types

> Test added in https://github.com/eclipse-openj9/openj9/commit/bd696339e6c06f77a6312a90126daec501c0e315 in ValueTypeTests.java The tests there are using generated VT classes, which will be eventually replaced. You can add the new test in a new file...

Use primitiveObjectHashCode function when hashing value types

> However changing all of those class names in both ValueTypeUnsafeTestClasses.java and ValueTypeUnsafeTests.java feels out of scope for this PR, so maybe I should make a new PR for testing...

Use primitiveObjectHashCode function when hashing value types

Test code is being added via https://github.com/eclipse-openj9/openj9/pull/16177.

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

Looking at the java stack: ``` "Thread-505" prio=5 Id=1625 RUNNABLE 16:13:09 at java.base@19-internal/jdk.internal.misc.Unsafe.park(Native Method) 16:13:09 at java.base@19-internal/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371) 16:13:09 at java.base@19-internal/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:506) 16:13:09 at java.base@19-internal/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3744) 16:13:09 at java.base@19-internal/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3689) 16:13:09 at java.base@19-internal/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitUninterruptibly(AbstractQueuedSynchronizer.java:1580) 16:13:09...

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

``` !j9vmthread 0x7f198091f400 J9VMThread at 0x7f198091f400 { Fields for J9VMThread: ... 0x90: struct J9ThreadMonitor* publicFlagsMutex = !j9threadmonitor 0x00007F1A1C22A078 0x98: UDATA publicFlags = 0x0000000000008020 (32800) 0xa0: UDATA compressObjectReferences = 0x0000000000000000 (0)...

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

There is a race condition. One thread is interrupting the target thread (setting `Thread.interrupted` to `true` and `J9THREAD_FLAG_INTERRUPTED` flag): https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/720d5357766d6cbb5dda08b469809da633f39129/src/java.base/share/classes/java/lang/Thread.java#L1757-L1759 Another thread is clearing the interruption (set `Thread.interrupted` to `false`...

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

The issue goes away with https://github.com/ibmruntimes/openj9-openjdk-jdk19/pull/51

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

PR to re-enable the test: https://github.com/adoptium/aqa-tests/pull/4187

jdk19 openjdk java/util/concurrent/tck/JSR166TestCase.java testAwaitUninterruptibly(ReentrantReadWriteLockTest): timed out waiting for thread to enter thread state WAITING

> PR to re-enable the test: https://github.com/adoptium/aqa-tests/pull/4187 Merged. Closing this issue.

Check file type for shared class cache jar files

Jenkins test sanity,extended plinux jdk17