openj9
openj9 copied to clipboard
Check file type for shared class cache jar files
Use the port library to check if path leads to a directory or file to support jar files that may not have the typical *.jar ending.
Fixes: https://github.com/eclipse-openj9/openj9/issues/19378
With this change the test described in https://github.com/eclipse-openj9/openj9/issues/19378 has 0% stale classes:
# Stale classes = 0
% Stale classes = 0%
Jenkins test sanity,extended plinux jdk17
Jenkins test sanity,extended win jdk8
Jenkins test sanity,extended xlinux jdk21
I aborted the JDK17_ppc64le_linux build as there are no machines available.
@theresa-m There are test failures on Windows Java 8.
jenkins line endings check
Jenkins test sanity,extended win jdk8
Jenkins test sanity,extended xlinux jdk21
Test failures in: https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.functional_x86-64_windows_Personal_testList_1/424/
From my understanding the failing tests cmdLineTester_SCHelperCompatTests_win_0
and cmdLineTester_SCHelperCompatTests_win_1
are meant to be disabled. See https://github.com/eclipse-openj9/openj9/pull/14474
They are only excluded for AOT testing. They run and pass nightly. https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk8_j9_sanity.functional_x86-64_windows/573
AOT testing is a special test mode where the tests are run once to populate AOT, and then run a second time to use the AOT.
I have verified with a personal build that windows sanity and extended tests are passing now.
I moved correctURLPath
inside getCpeTypeForProtocol
so that all calls to this method will have the correctly formatted path for windows.
Thanks Hang and Keith, this is ready for another review.
Jenkins test sanity,extended alinux jdk21
Jenkins test sanity,extended win jdk8