openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Check file type for shared class cache jar files

Open theresa-m opened this issue 10 months ago • 12 comments

Use the port library to check if path leads to a directory or file to support jar files that may not have the typical *.jar ending.

Fixes: https://github.com/eclipse-openj9/openj9/issues/19378

theresa-m avatar Apr 25 '24 18:04 theresa-m

With this change the test described in https://github.com/eclipse-openj9/openj9/issues/19378 has 0% stale classes:

# Stale classes                      = 0
% Stale classes                      = 0%

theresa-m avatar Apr 25 '24 18:04 theresa-m

Jenkins test sanity,extended plinux jdk17

hangshao0 avatar Apr 30 '24 14:04 hangshao0

Jenkins test sanity,extended win jdk8

hangshao0 avatar Apr 30 '24 14:04 hangshao0

Jenkins test sanity,extended xlinux jdk21

hangshao0 avatar Apr 30 '24 15:04 hangshao0

I aborted the JDK17_ppc64le_linux build as there are no machines available.

hangshao0 avatar Apr 30 '24 15:04 hangshao0

@theresa-m There are test failures on Windows Java 8.

hangshao0 avatar Apr 30 '24 18:04 hangshao0

jenkins line endings check

hangshao0 avatar May 08 '24 19:05 hangshao0

Jenkins test sanity,extended win jdk8

hangshao0 avatar May 08 '24 20:05 hangshao0

Jenkins test sanity,extended xlinux jdk21

hangshao0 avatar May 08 '24 20:05 hangshao0

Test failures in: https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.functional_x86-64_windows_Personal_testList_1/424/

hangshao0 avatar May 09 '24 13:05 hangshao0

From my understanding the failing tests cmdLineTester_SCHelperCompatTests_win_0 and cmdLineTester_SCHelperCompatTests_win_1 are meant to be disabled. See https://github.com/eclipse-openj9/openj9/pull/14474

theresa-m avatar May 17 '24 14:05 theresa-m

They are only excluded for AOT testing. They run and pass nightly. https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk8_j9_sanity.functional_x86-64_windows/573

AOT testing is a special test mode where the tests are run once to populate AOT, and then run a second time to use the AOT.

pshipton avatar May 17 '24 14:05 pshipton

I have verified with a personal build that windows sanity and extended tests are passing now.

I moved correctURLPath inside getCpeTypeForProtocol so that all calls to this method will have the correctly formatted path for windows.

theresa-m avatar May 21 '24 12:05 theresa-m

Thanks Hang and Keith, this is ready for another review.

theresa-m avatar May 21 '24 19:05 theresa-m

Jenkins test sanity,extended alinux jdk21

keithc-ca avatar May 23 '24 20:05 keithc-ca

Jenkins test sanity,extended win jdk8

hangshao0 avatar May 23 '24 20:05 hangshao0