Hang Chen

Results 97 comments of Hang Chen

@dennyglee @scottsand-db Please help take a look, thanks a lot.

@scottsand-db @dennyglee Would you please help take a look if you have time?

> I will work on this issue this week. Please assign this issue to me and hang chen. Yes, we are working on this issue. Please assign this issue to...

@merlimat Thanks for your contribution. Would you please rebase the master? thanks.

The CI failed, https://github.com/apache/bookkeeper/runs/7672152565?check_suite_focus=true, please help take a look, thanks.

It looks like the ledgerId is < 0, which will lead to the above exception. I wonder whether your ledger log file is broken. https://github.com/apache/bookkeeper/blob/de5d45fb823dc558f15bcb9d958b9c0a5144043c/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java#L1007-L1011 It throw exception in `scanner.accept(ledgerId)`

ping @CalvinKirs, do you have time to resolve the above comments?

Sharing the write cache pool with all ledger disks may cause competition for write cache resources, and eventually cause some ledger writes starve to death because they cannot get the...

> it's better to add proper test case to avoid future regressions @nicoloboschi I have added the test to cover this change, please help take a look, thanks.

@merlimat @eolivelli @nicoloboschi @gaozhangmin @lordcheng10 I have updated the code and added the test to cover this change, Please help take a look, thanks.