Dan Handwerker

I would like to switch from correlation to T and F values which would make polynomial detrending possible. This is critical since we don't want a slow drift to mean...

I think #1064 replaces this and that one is a branch of `/ME-ICA/tedana` so it will be a bit easier for several of us to add stuff to if. @tsalo...

> The results are now substantially different: > I do expect the values to be non-trivially lower because you were including voxels with 1 good echo, which meant fit coefficients...

For better and worse, we are calling sklearn.decomposition.PCA and we are replicating their terminology ( https://scikit-learn.org/stable/modules/generated/sklearn.decomposition.PCA.html ) The actual call in tedana is here: [ppca = PCA(copy=False, n_components=algorithm, svd_solver="full")](https://github.com/ME-ICA/tedana/blob/e94b03a604283c608a518e8390713ddd29d52ea9/tedana/decomposition/pca.py#L317C18-L317C18) I...

With the way we're currently using nomenclature, "Decision Tree" are the steps in the process for deciding while "Selector" is the processing the does several things including validating and running...

> I guess the core issue is that the kundu method isn't finding a local minimum so it's not actually a plot and there isn't even a threshold. The number...

@tsalo I'm realizing that to specify the external metrics in the decision tree json, like you requested in https://github.com/tsalo/tedana/pull/14 it will be much easier if we merge this first. I've...

> One thing I'm realizing here is that the current approach of passing the selector into decision functions and modifying it within them is unfortunately fragile. Given that the decision...

One other nomenclature thing. If this class is now for metrics and selection and is loaded much earlier in the workflow, is it still the `Component_Selector` class with the object...

I don't want to keep opening pull requests, but I'm working here https://github.com/handwerkerd/tedana/tree/gen-req-metrics-dh and I'll open a PR when I think this is reasonably stable. I identified one issue that...