Henry Andrews

Results 1298 comments of Henry Andrews

> But if you want to, you can explicitly choose which draft to use. Seems pretty important to me to support the latter if you're going to support multiple drafts...

> A large automated change adding $schema to all schemas is essentially impossible to code review Well I strongly disagree with that but this is your package so I won't...

@Julian I apologize for pushing on the bulk change topic. Please feel free to edit out any comments, in whole or in part, that you feel detract from the point...

@Julian, the role of `$schema` has changed over time. Originally, it didn't exist at all. In drafts 3 and 4, it was presented as an inessential nice-to-have, which made your...

Thanks, @Julian From [§8.1.1 The "$schema" keyword](https://www.ietf.org/archive/id/draft-bhutton-json-schema-01.html#name-the-schema-keyword): > The "$schema" keyword SHOULD be used in the document root schema object, and MAY be used in the root schema objects of...

@embray https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#dataTypeFormat

(although note that their `byte` and `binary` formats should actually be handled wth `contentEncoding`)

@iainbeeston @epoberezkin @Julian can anyone summarize what's going on here and where we are? We'll also want to copy these to draft-07 (which is backwards-compatible with draft-06, so that should...

@Julian > did you also re-add the optional test not containing $schema for implementations choosing to indeed process them? Oops forgot about this, I'll look into it and update the...

@Julian updated with optional tests. TIL that `type` has not always been the same across all drafts! It only took on its current form in draft-03. Prior to that it...