Michael Miday

Results 39 comments of Michael Miday

@neuropass This is absolutely required and not bloat. Its is a UI requirement to have an avatar going forward with any application today. In order to facilitate that you have...

what you do not understand, is that it cannot be an ext if it is required by another aspect of the core. If the templating system requires it then it...

for this to work properly we need to establish the requirements for the avatars. First we want all avatars to be physically 2x the size we need to use them....

@marc1706 apart from the conflicts being fixed. I think all else should be good based on our conversation about splitting things off. I will look into the conversion on my...

There is not css here so you do not need the styles label

probably cleaner to just add a class var to the arrays and a new param to the build function with a class which equals the array index and you could...

yeah, cause it's not clear or clean which is why I suggested this way, also they need to have classes anyway for the new theme. either way, its probably going...

Approved the other PR, but this one needs rebased against master branch. I changed the baracnh but you will need to resolve any conflicts. I should point out that this...

Looking at this again the best way would be to refactor all of this into a proper twig Form function of some kind to handle them all consistently

@hubaishan can you please rebase this on master branch