Hamza Sheikh

Results 6 comments of Hamza Sheikh

Is this issue still relevant? Happy to work on it if no one is.

I just want to make sure I understand the requirement correctly after skimming the codebase and running the example. In the current state, the peer command handles the outgoing peering....

Both unpeering commands delete the foreign cluster resource. The unpeer out-of-band have a [boolean](https://github.com/liqotech/liqo/blob/f3f48579db504b543c2bb6ddcda6b5230a825594/pkg/liqoctl/unpeeroob/handler.go#L40) that prevents that, but is [always set to true](https://github.com/liqotech/liqo/blob/f3f48579db504b543c2bb6ddcda6b5230a825594/cmd/liqoctl/cmd/unpeer.go#L131) at the moment.

Sorry, my comment was ambiguous. No change is being made to the outgoing peering. The flag only changes incoming peering variable in foreign cluster spec. I'm pointing out that the...

The flag should work as expected now. Running peer and unpeer commands with the --incoming flag will only change the foreign cluster resource .spec.incomingPeeringEnabled to yes and no, respectively. Can...

The peer and unpeer commands should be working as intended. I'm not waiting on the peering status change, but the change in the foreign cluster resource: 1- https://github.com/hamzalsheikh/liqo/blob/860d783a992ff06c1a967d9532773875682082a1/pkg/liqoctl/wait/wait.go#L81 2- https://github.com/hamzalsheikh/liqo/blob/860d783a992ff06c1a967d9532773875682082a1/pkg/liqoctl/wait/wait.go#L136