Hans Moritz Günther

Results 445 comments of Hans Moritz Günther

I suggest that this new reader be the default at least and we keep the old ECSV reader with a different name (`ascii.ecsv_deprecated`) for one version and then remove it....

I don't even think we need a separate command. The command can just be `plot("data", "model")` and if you have 1D data, you get a line plot, if you have...

I want to mentions that this PR serves as a general proof-of-concept for setting up models across multiple spectra. I have several non-IXPE use cases for a similar mechanism (instead...

I'm very opposed to just silently ignoring the setting. And, I've never used `save_all`. Maybe I should, I just never knew about it. Anyway, a compromise could be to issue...

Apart from the discussion on "should there be a message if I try to change it", the implementation seems uncontroversial. Since the setting is not used, cannot be changed and,...

Either way works for me. I'd be OK with having as is and just adding an Exception/Warning for the cases where there is no backwards-compatibility issues (the Arithmetic models). We...

This is still marked as WIP, but it also has a request to review for me attached. So, just checking: Is this just open "for reference" as other PRS (like...

Thanks for tagging me in this - I did not even know that the wstst statistic exists at all, so I've never wondered how it should be visualized. Turns out,...

Unfortunately, I'm not able to use this statistic: ``` --------------------------------------------------------------------------- StatErr Traceback (most recent call last) in 1 ui.set_stat("wstat") 2 ui.set_model(ui.xsphabs.abs1 * ui.xsapec.ap1) ----> 3 ui.fit() in fit(id, *otherids, **kwargs)...

``` name = TYC_2597_735_1.pi channel = Float64[1024] counts = Float64[1024] staterror = None syserror = None bin_lo = None bin_hi = None grouping = None quality = None exposure =...