Hamid Zare

Results 43 comments of Hamid Zare

closed in https://github.com/determined-ai/determined/pull/5115

I need to move this pr to an upstream branch https://circleci.com/gh/determined-ai/determined/963572

thanks for the review. > This is looking good. Thoughts on using a separate context provider for the store information? what do you mean by the store information? as in...

my plan was to not update the references here so I can land this sooner so we can use it sooner. but there aren't that many references and it'll let...

moving this to an upstream branch so the tests can run https://github.com/determined-ai/determined/pull/5338

tests failing on https://determinedai.atlassian.net/browse/DET-8462 the story for this comp https://deploy-preview-5109--storybook-det.netlify.app/?path=/story/shared-avatar--default&args=noColor:true

> looks like DET-8462 is complete so i updated with master and still seeing a failure, would i expect to see that fixed? @hamidzr would also appreciate stamp for this...

https://app.circleci.com/pipelines/github/determined-ai/determined/28435/workflows/881047cc-44b0-462e-a677-11dcb6e32a66/jobs/958836 it skipped the tests and passed => showing the bug

after https://github.com/determined-ai/determined/pull/5115/commits/e746ce51d507356e584786d6946f61e9d584ac8b it correctly detected the change and failed as expected for this case. https://app.circleci.com/pipelines/github/determined-ai/determined/28436/workflows/d1f3975c-98b5-40f6-bffb-7914c975e8c1/jobs/958878

I saw some seemingly unrelated test failures and updated the branch https://app.circleci.com/pipelines/github/determined-ai/determined/28437/workflows/bab576a7-3db0-4135-8afb-8dd1f70b0a50/jobs/958936