determined icon indicating copy to clipboard operation
determined copied to clipboard

test: fix shared tests skipping unintentionally [DET-8034]

Open hamidzr opened this issue 1 year ago • 2 comments

Description

Test Plan

  • show the bug: test being skipped when there is a file added to webuil/react/src/shared
  • show test running as expected https://app.circleci.com/pipelines/github/determined-ai/determined/27595/workflows/eb203a5f-c8ca-4420-8224-45bdb727dbf4/jobs/924114

Commentary (optional)

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

hamidzr avatar Sep 21 '22 23:09 hamidzr

Deploy Preview for storybook-det canceled.

Name Link
Latest commit ccc2d0f00a7a1a23d326c97ce39a68e35ef75825
Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/632bb5a12da0ba00083d8f8c

netlify[bot] avatar Sep 21 '22 23:09 netlify[bot]

Deploy Preview for determined-ui ready!

Name Link
Latest commit ccc2d0f00a7a1a23d326c97ce39a68e35ef75825
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/632bb5a0c8a99b000890d9ba
Deploy Preview https://deploy-preview-5093--determined-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 21 '22 23:09 netlify[bot]

closed in https://github.com/determined-ai/determined/pull/5115

hamidzr avatar Oct 10 '22 20:10 hamidzr