Hamdi Allam

Results 47 comments of Hamdi Allam

Thanks for the contribution!

0.9.0 hasn't been released yet. Can we make this

Hey! Not that i'm aware of Let me update and see what happens. With backwards compatibility, I haven't been as diligent in updating/checking till folks ask

The [TraceInitializerFilter](https://github.com/twitter/finagle/blob/develop/finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala#L62) is responsible for initializing the trace id for the request to be handled. This is placed low in the stack before any other modules that might emit traces....

That implementation looks correct. Glad it's working. I'll keep this issue open to find some time to design better integration

Can you paste outputs from something like async profiler? (https://github.com/jvm-profiling-tools/async-profiler) This seems to be more of a problem with AdoptOpenJDK perhaps? Have you tried to see if this regression is...

Hey! Sorry for not getting around to this. Just synced with some more folks internally. Our current builds and runtime environments are targeted towards JDK 8. JDK 11 is currently...

Also thanks for the time it took to produce this data. It's super helpful

Where is the blocking code being run? The same thread will run continuations for Twitter Futures & Promises if you adjusted the following, I believe you'll see the desired affect....

@politrons Can you clarify how the suggestion I posted does not work? I tried it out right now and does. It's the same mechanism in the OffloadFilter In this example...