Benjamin Halsted

Enabling #[serde(deserialize_with=...)]

1

The code had been returning errors too early to allow for `deserialize_with` to work. If the visitor does not receive the expected type, it'll try `deserialize_any` so that conversions can...

Enabling #[serde(default)]

8

Added de-serialization from a js_sys::Map. This makes it easier to use data from the result of `DurableObject::load()`. Having #[serde(default)] enables a simple, yet effective data migration.

Documentation for SpatialMaterial::set_flag is incorrect.

1

https://docs.rs/gdnative/0.9.3/gdnative/api/struct.SpatialMaterial.html#method.set_flag Should read: ``` If true, enables the specified flag. Flags are optional behaviour that can be turned on and off. Only one flag can be enabled at a time...

Cargo run --example name

2

Update the workspace to make it easier to run examples after checking out the repository.

Class docs for `gdnative::api::object::Object` should somehow reveal that `gdnative::api::object::ConnectFlags` exists.

The `Fds` struct used in `ListenFds` in the `pingora::services::Service` trait is not nameable. See https://rust-lang.github.io/rfcs/2145-type-privacy.html#lint-3-voldemort-types-its-reachable-but-i-cant-name-it This change makes both `ListenFds` and `Fds` public. As a side-effect all of the methods...

Not possible to implement `pingora::services::Service` due to `Fds` not being available.

5

## Describe the bug When trying to implement `pingora::services::Service` the `Fds` struct is not public because the `transfer_fd` module is private: ```error[E0603]: module `transfer_fd` is private``` ## Pingora info **Pingora...

Emote identifiers can be strings

1

For example, with subscriber emotes the id is a string like: `emotesv2_c9b440ae1089457fbec4bd83ce091b0a` Full Privmsg dump: ```rust Privmsg { raw: "@badge-info=;badges=;client-nonce=6165e054a7a023fdc345cc99944d9090;color=#FF9CEE;display-name=GlitchButSmol;emote-only=1;emotes=emotesv2_c9b440ae1089457fbec4bd83ce091b0a:0-9/emotesv2_99e7ca82ee744cae9f54dced65ea4658:11-21/emotesv2_fb79a7ffecfc4ff89486317d0d8bd582:23-36;first-msg=0;flags=;id=d642db40-fddf-4c07-bc9d-43779f15dbdf;mod=0;returning-chatter=0;room-id=75244893;subscriber=0;tmi-sent-ts=1669989103046;turbo=0;user-id=403440621;user-type= :[email protected] PRIVMSG #mrhalzy :breade3Box icedkiSleep idlefaBlankies\r\n", tags: { "badge-info": "",...

VIM mode in Zed was not responding to the ESC key without this change. The keyboard layout had period in two places, fixed one to be backtick (which was missing).