halftrainedharry

Results 46 comments of halftrainedharry

What is the response if you open the image URL "URL/connectors/system/phpthumb.php?src=PATH_TO_IMAGE&w=335&h=236&HTTP_MODAUTH=AUTH_ID&zc=1" directly in the browser? With MODX 3.0.1 and PHP 8.1 I get an error message `Deprecated: strtolower(): Passing null...

I would leave the issue open. At least when the installation is in a subdirectory (`base_url` is different from `/`) the image path is incorrect and that needs to be...

I added a line to the snippet to add the package and this indeed helped somewhat. The file `mysql/MyClass.php` is correct now, but the file `MyClass.php` still contains some placeholders:...

The problem seems to be this line in the code: https://github.com/modxcms/revolution/blob/f7bc0133f5f09184418a7ddf6f9b98a3f0decd9e/setup/includes/runner/modinstallrunner.class.php#L170-L177 I don't think the problem is the double backslash in the config file `\\` (as the backslash is an...

The problem seems to be this line in the _sanitize_ function that removes the dot from the file name. https://github.com/modxcms/revolution/blob/26866e13963084610bb03c89b635654813f55a86/core/src/Revolution/Processors/Browser/Browser.php#L146

I believe it is a problem with the capitalization (lowercase/uppercase letters). Can you change this line in the code https://github.com/modxcms/revolution/blob/5e3c5eaca9a9e6cf3ebf0f7eb142fb4506534fb9/core/src/Revolution/Processors/Security/Access/UserGroup/ResourceGroup/GetList.php#L148 to ``` 'handler' => 'this.confirm.createDelegate(this,["Security/Access/UserGroup/ResourceGroup/Remove"])', ``` and check if that...

This is a known issue related to this line in the code: https://github.com/modxcms/revolution/blob/cb6f56a19af818ad4d1d62dc0d31b9819aaa876f/core/src/Revolution/Filters/modInputFilter.php#L56 The regular expression was changed in #14458 to allow nested output filters, but causes a lot of...

It seems that in 2.x the parameter `key` was used to filter the settings https://github.com/modxcms/revolution/blob/7d5e18753c0629aa4d60de134ac2945600e5cb0c/core/model/modx/processors/system/settings/getlist.class.php#L54 but in 3.x the parameter is called `query`. https://github.com/modxcms/revolution/blob/b5d9b3459bc56590a4bacda89302100a35ca8212/core/src/Revolution/Processors/System/Settings/GetList.php#L63 --- Maybe the query parameter in...

Currently the file name is generated entirely in Javascript with a regex that deletes every character not in `\w` (`[A-Za-z0-9_]`) except for `-`. https://github.com/modxcms/revolution/blob/66e254d6d5d9370d5fcfa7cd73b705dace6e0d0e/manager/assets/modext/core/modx.js#L391-L393 As the transliteration for the resource...

Can we please revert PR #14458 until someone is able to come up with a solution that works reliably. The problems with this change keep piling up here on github...