Håkon Wiik Ånes
Håkon Wiik Ånes
Actually, come to think of it, it will be challenging to test at least the CrystalMap docstring examples without a `orix.data` module to load example data from (as explained here...
Great! > We can then tackle this problem at the `0.7`, my instinct (keep packages small on pypi) is being offset by the fact kikuchipy only runs to 5MB. But...
When we do this, we can add a few example docstrings as well, including the one mentioned in https://github.com/pyxem/orix/pull/202#issuecomment-860565878.
Hm, I don't know the reasoning for the design choice, and I'm in favour of changing it to work similar to NumPy broadcasting. Might be worth keeping the discussion in...
I agree that orix should be consistent with NumPy.
Glad to hear you would like this as well! I think introducing the scikit-image dependency should be fine, since I think many people using orix already have scikit-image installed in...
I've started on this class, but it won't be ready for v0.6, so I've pushed it back to a v0.7. I also think `orix.map_feature.MapFeature` is a better name, since `Feature`...
`Region` is good, and used by scikit-image for the `regionprops` (see link in top comment). Perhaps `MapRegion` is even better? But region is better than feature, definitely.
I've worked some more where I need this class, and I think `MapRegion` is an even better name than `Region` because then we avoid potential confusion with `OrientationRegion` and `SphericalRegion`.
Also, although scikit-image's `regionprops()` has lots of properties we would need from the start, I think it is best to build this class up from nothing, since `regionprops()` returns a...