Håkon Wiik Ånes
Håkon Wiik Ånes
Hm, the references you're giving above to Bunge and Rowenhorst et al. are in line with https://github.com/pyxem/orix/pull/234#issuecomment-988136832, right? Code in that comment use existing orix functionality (and the current status...
> I agree with the comment above That's a relief! The list of conventions to write down in the documentation looks good. > I (personally) find the terminology needlessly involved...
We wait to 0.9 for documenting these conventions, right? If so I think #236 must wait as well.
Actually, we could do a v0.8.1 with documentation of these conventions, as I don't see any new functionality being added. What do you think?
I prefer notebooks because then we can explain the conventions with examples and plots. Much like the previous notebook I've listed above with unit cell plots, IPFs and PFs.
Oh, I misunderstood you and spoke to strongly... Sorry. We fully agree then! Should we have a minimal example of this in v0.8?
Good point. I'll fix this now, as I have to fix `setup.py` for uploading to PyPI.
Fantastic, everything works ([log](https://github.com/pyxem/orix/runs/6371223381?check_suite_focus=true)) except the cell in the "Clustering orientations" notebook printing the time for `get_distance_matrix()`, which we shouldn't expect to be the same for my machine (slightly faster)...
Yes, we should add that metadata to the relevant cell!
Thank you for listing these use cases, we should provide sensible returns for all of them. I've updated the top comment with your suggestions. This https://github.com/pyxem/orix/issues/249#issuecomment-1033751210 by @harripj on the...