Håkon Wiik Ånes

Results 530 comments of Håkon Wiik Ånes

@CSSFrancis, I'd appreciate it if you could have a look at the new examples, the rephrased docstring of `get_sample_reduced_fundamental()`, and the reworked test of that function.

> It's probably not super simple as the align vectors can handle the case where you are trying to align multiple vectors but we could also just add the function...

kikuchipy's tests pass with this branch. The functionality in kikuchipy relying on reduction to Rodrigues fundamental zone is the uniform sampling of orientations. This seems to be unaffected by this...

Considering the change in this PR, the notion of the first and second symmetry in `OrientationRegion.from_symmetry(s1, s2=C1)` changes meaning, I think. I suggest to change parameter names to `start, end`...

Talked to @anderscmathisen offline, reduction to the FZ now seems to make sense for his use.

That would be great. This change only lives in my fork so far, which you should be able to install into an environment like so: ```bash pip install git+https://github.com/hakonanes/orix.git@fix-misorientation-reduce ```...

Happy to hear that, thank you for doing the tests. Please report back if you still find inconsistencies.

FYI, @DorianDepriester checked out the changes in this PR on his calculation of weighted mean orientations in https://github.com/pyxem/orix/issues/434#issuecomment-1513203390 and got results in line with his expectations.

Thank you for sharing this test, @maclariz. I believe this is related to (inconsistent?) alignment of crystal axes with symmetry operations. I've encountered issues with point group -3m myself (chromium...

> To easily debug these things, I suggest we implement automatic plotting of [symmetry elements in the stereographic projection](https://orix.readthedocs.io/en/stable/examples/stereographic_projection/plot_symmetry_operations.html) for all defined point groups. I've started to work on this...