Tomas Rimkus

Results 312 comments of Tomas Rimkus

@braaar you don't have permission to merge?

At this point you might just fork the project. It doesn't seem like @NoNameProvided has any plans to work on this anymore.

Pretty much the same applies to `tui-doc-page`. Proposed design (`tui-doc-tab` instead of `ng-template`): ```html Foo Bar! ``` versus the current one: ```html Foo Bar! ```

It's not only about how short it is. - `ng-template` tag is ambiguous. By just looking at the tag name, you can't tell what it's supposed to do here. -...

How does it make sense having `tr` inside `tui-doc-documentation`? Or do you want to have sth like the following: ```html Foo bar ``` which doesn't make much sense to me...

> `ng-template` is not ambiguous, it means a piece of content that is declared but not instantiated. I know what `ng-template` does. My point is that it is basically a...

BTW, just checked how Angular Material tabs are implemented. They use component selector `` and the template looks like this: ```html ``` [Source](https://github.com/angular/components/blob/master/src/material/tabs/tab.html)

> You get proper IDE auto-completion for directives on `ng-template` from currently imported modules: > ![image](https://user-images.githubusercontent.com/11832552/132251062-505e07a7-10ee-4dcc-a3a6-b684a63768f1.png) That's a very simplistic contrived example where the attribute selector is a simple `pageTab`...

Might be a problem with an old TypeScript version on the user side. Type definition generated with newer TS version might be incompatible with an older lib user TS version.