Tomas Rimkus
Tomas Rimkus
I am quite busy right now, but might be able to take a look at this at the end of next week. If someone wants to take this before that,...
Quickly took a look at this and it seems to me that for `multi-select` to accept `input[tuiTextfield]`, `input-tag` template needs some major changes which include replacing simple `input` with `primitive-textfield`....
@splincode the mentioned PR doesn't fix the issue. We need second generic on the `open()` method to type `data` config, not a way to pass any Angular component to `open()`....
Your workaround doesn't seem to work: 
`Partial` is almost as long as `AbstractTuiDialogService` and not that much better workaround. `open()` definitely needs a second generic and, honestly, I don't see how that can break anything.
Almost, just instead of `this.dialogs.open()`, I would like to simply use `this.dialogs.open()`. Basically, I don't think `TuiDialogOptions` should be mandatory. Anyway, it could be a good start.
Maybe `DialogService` could override the `open()` method from the abstract class to set different generics.
Not a fan, to be honest. - You still have to declare dialogs like `dialogs = inject(TuiDialogService)` - It looks like it would break `MobileDialogService.open()` typings and it doesn't fix...
Only if @waterplea is willing to accept the changes I mentioned.
It only remains an issue if you don't want to define your dialog as a property of the component and instead instantiate it in a method. Or if you don't...