Tomas Rimkus

Results 312 comments of Tomas Rimkus

Ok, I can confirm that it works correctly with `replace-in-file` `v6.3.5`, but not with the latest `v7.0.1`. So it's an issue with `replace-in-file` library.

@shaharkazaz the person who reported [the issue](https://github.com/adamreisnz/replace-in-file/issues/165) in `replace-in-file` repo fixed it by [changing path match patterns](https://github.com/windingwind/zotero-plugin-template/pull/63/files#diff-d3831cd61824ee8713cea7361c0fe4cb921f80deb8eaec5ebccc434be0e96d6eL133). So, I'm not sure if it would be best to downgrade the library...

I only know what the bug reporter wrote. In the bug report he wrote: ``` We replaced RplaceInFileOption.files with the correct glob pattern and it works fine, however in 6.3.5,...

Do you want to open a PR in `replace-in-file` repo?

Ok, for now I can just pin `replace-in-file` version on my end: ```json "resolutions": { "replace-in-file": "6.3.5" } ```

@shaharkazaz are you going to create a PR in `replace-in-file` or should I do it?

PR: https://github.com/adamreisnz/replace-in-file/pull/169

Another solution could be to use getter: ```ts get selectAll$() { return this.selectAll(); } ```

There is a link to an updated version of the library with full updated readme.

I have forked the library and published a version which works with GA4 and Angular 16. [Release announcement](https://github.com/hakimio/ngx-google-analytics/releases/tag/15.0.0) [Installation and usage](https://github.com/hakimio/ngx-google-analytics#readme)