Haikal Ryclova-Pribadi comments

Results 94 comments of


                                            Haikal Ryclova-Pribadi

Attribute has a generic type parameter, but AttributeType doesn't

The interface in Grakn Core does not have generics, @alexjpwalker - which is what matters for the Grakn Client, I believe. https://github.com/graknlabs/grakn/blob/master/concept/thing/Attribute.java So I think we should remove the generics...

Upgrade cucumber to access @BeforeAll and @AfterAll

Let's find out the difference with `@BeforeClass` and `@AfterClass`

Integration tests are messy and full of commented code

Being too precise by adding both `feature` and `refactor` is not actually helpful as it becomes confusing @alexjpwalker. I think just labelling it `refactor` here, as it is more of...

Clicking on scrollbar area before it's shown, crashes with "Cannot round NaN value"

Okay, I found a temporary patch to use for now, but ideally we should not need this. ```kotlin val maxOffset = adapter.maxScrollOffset(0) if (maxOffset > 0 && maxOffset < Int.MAX_VALUE)...