typedb-driver icon indicating copy to clipboard operation
typedb-driver copied to clipboard

Integration tests are messy and full of commented code

Open alexjpwalker opened this issue 3 years ago • 3 comments

Problem to Solve

The integration test package is messy and full of commented code.

Proposed Solution

  • Many of the comments say "re-enable when X is implemented". X is, in fact, typically implemented, so we should simply be able to uncomment them (and presumably update them to 2.0 syntax)
  • The parallelQueriesInTransactionTest can most likely be simplified. While we do want the queries to be quite heavy in order to verify that the issue it highlighted (non-threadsafe use of StreamObserver) is actually resolved, there seems to be a lot of code duplication in this test.
  • integration/concept is no longer needed.

alexjpwalker avatar Apr 06 '21 16:04 alexjpwalker

Should the label be bug or refactor @alexjpwalker ? From what I see, it's about enabling disabled tests, updating the syntax and simplifying the test structures.

lolski avatar Aug 24 '21 11:08 lolski

@lolski Updated to feature and refactor as there is a bit of both involved (regarding tests as features)

alexjpwalker avatar Sep 02 '21 13:09 alexjpwalker

Being too precise by adding both feature and refactor is not actually helpful as it becomes confusing @alexjpwalker. I think just labelling it refactor here, as it is more of a refactor, is much clearer.

haikalpribadi avatar Oct 26 '21 20:10 haikalpribadi