Hadrien Kohl

Results 17 comments of Hadrien Kohl

I think the `WriteMessages()` implementation is problematic in several ways: It can either be asynchronous or not, depending on the config. I think we should have dedicated async methods. Something...

> The segmentio/stats library includes a [prometheus integration](https://pkg.go.dev/github.com/segmentio/[email protected]+incompatible/prometheus), so are you describing a limitation in that integration you are trying to work around? (in which case, a PR to segmentio/stats...

For context, here's what I ended up with: ```go type ReaderCollector struct { Reader *kafka.Reader } var ( labels = []string{"client_id", "topic", "partition"} dialsDescription = prometheus.NewCounterVec(prometheus.CounterOpts{Name: "kafka_reader_dial", Help: "Count the...

Hi, I see this PR has been pending for almost a year now. Do you need any help? I can test locally or contribute if there's more to do.

You really should use Docker.

Until the `zoneWidget` API is available this is an example of how you could implement the trick explained above. ```javascript // Create a zone over the margin. Uses the trick...

I suppose we could add a comment somewhere about the fact that only metrics recorded after the handler is called are modifiable using a `Labeler`.

Tried hard to add the route tag to the `active_request` but since it has to be started _before_ the tag is injected using the `Labeler` there's way to fix that...

Anything else you need me to do on this PR?

Groups are not implemented unfortunately.